Refactor opts #2829
Merged
Refactor opts #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This might be a good place to cherry-pick some of the new verbiage from shykes#63, to help cut down on merge work later. |
Contributor
Author
|
@tianon: done |
Member
|
👍 |
Contributor
|
@creack when you cherry picked, you imported:
Could you remove it (it's unused outside 0.7) |
Contributor
Author
|
@vieux done |
Contributor
|
@creack this needs to be rebased |
added 2 commits
November 26, 2013 17:46
Contributor
Author
|
@vieux done |
Contributor
|
@crosbymichael let's be careful on this one 😆 |
Contributor
Author
|
ping @vieux @crosbymichael @shykes. Unit tests are in #2892 |
added 2 commits
November 28, 2013 12:23
Conflicts: commands.go
Contributor
Author
|
ping @vieux @crosbymichael @shykes. Unit tests are in #2892 |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor *Opts in order to make the code more consistent and easy to read.
Before the PR, we had some opts that used Custom type, other the utils.ListOpts, some validations by type, some somewhere else.
This PR tries to clean things up.