Conversation
CHANGELOG.md
Outdated
There was a problem hiding this comment.
- For overlay/overlay2 storage drivers, backing filesystem without d_type is deprecated overlay: warn if overlay backing fs doesn't support d_type #27433
There was a problem hiding this comment.
@AkihiroSuda looks like that was not yet added to the deprecated.md file, can you open a PR for that?
55f8038 to
05063a3
Compare
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Why is this in CLI and "allow parallel stop, pause, unpause" in Runtime. Essentially they should be same bullet point with 2 PR links(improve stopping, removing and pausing).
CHANGELOG.md
Outdated
There was a problem hiding this comment.
This could be in distribution on security.
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should be moved to logging yes
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
There was a problem hiding this comment.
needs to be after actual feature --init
There was a problem hiding this comment.
This is a separate flag; --init-path
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Add workaround for overlay issues during build in older kernels.
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should add new options --autolock and swarm unlock here?
There was a problem hiding this comment.
I think the current line is sufficient. It would be a lot of information to describe the new options and commands in this changelog entry.
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
There was a problem hiding this comment.
This is filtering volumes by label
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Just realized this is "experimental", so we should prefix with (experimental) ?
CHANGELOG.md
Outdated
There was a problem hiding this comment.
move this down, together with the other prune commands
CHANGELOG.md
Outdated
There was a problem hiding this comment.
maybe we should change "collect" to "view"
CHANGELOG.md
Outdated
There was a problem hiding this comment.
backticks around /sys/firmware/**
9901f02 to
2f967e7
Compare
|
@thaJeztah @cpuguy83 I addressed your comments @tonistiigi all but one comment addressed (I ask @aaronlehmann for a good description) |
9f88a25 to
bc46212
Compare
CHANGELOG.md
Outdated
There was a problem hiding this comment.
nit: and Windows 10 (right?)
There was a problem hiding this comment.
Well... I dont think overlay networking will work in windows 10. So, technically yes, windows 10 as well. But practically I haven't tried an alternative (such as a network plugin that provides the overlay functionality for windows 10.
@msabansal wdyt ?
There was a problem hiding this comment.
@mavenugo , @msabansal really excited to see windows support for overlay and native 'swarm' mode. Would i be able to try these out if i pick the latest binaries from master.dockerproject.org, or i would need some upcoming updates for windows server 2016 (because i saw that mentioned somewhere). Please let me know as i can keep me from trying this out :)
There was a problem hiding this comment.
@git-jiby-me you should be able to try native swarm mode without the overlay driver. overlay driver would require a windows update.
|
@mavenugo yes, thanks! |
61dfbb8 to
5cd533e
Compare
vdemeester
left a comment
There was a problem hiding this comment.
Few comments 👼.
The templating support for Swarm Mode (#28025 — there was no changelog tag but I feel it could be in the changelog) is missing too 😝
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should this be Add step number on … (makes it a little more readable, at least for me 👼)
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should we precise it's --publish flag on docker run ?
CHANGELOG.md
Outdated
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Could be grouped with --mount one 👼
CHANGELOG.md
Outdated
There was a problem hiding this comment.
docker create has them too 👼
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Should this go into Swarm Mode ?
5cd533e to
9bfdb57
Compare
|
@vdemeester updated |
Signed-off-by: Victor Vieux <vieux@docker.com>
|
@vieux just 1 comment above : #28275 (comment) |
|
And possibly this one for the API deprecation #27872 |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
- Enable ping for service VIP address #28019
9bfdb57 to
bbf7cad
Compare
bbf7cad to
433bb52
Compare
|
@thaJeztah done |
He's busy right, but I addressed all his comments.
|
LGTM |
ping @docker/core-engine-maintainers