Add external binaries version to docker info #27955
Conversation
74042c2 to
9e2fe66
Compare
|
Example run? Is there an issue? Are we having trouble debugging something specific that this would help? |
|
It's mostly for users that are not using docker official packages. Or to spot easy to figure out "error" like them having replaced one of the binaries for testing and forgotten about it. It's also nice to have it all in one place. It's just information. |
9e2fe66 to
e0275ff
Compare
hack/make/.go-autogen
Outdated
There was a problem hiding this comment.
I don't understand why this hardcoded
There was a problem hiding this comment.
Oups, bad commit -_-
|
I think this should be solved by having |
e0275ff to
3c9cf9c
Compare
|
@LK4D4 not all users have access to their daemon host Also, I think having users only run 1 command to get this information is preferable than asking them to run |
|
from a "support" perspective, I think it'd be great to have it all in |
|
I do agree with @thaJeztah and @mlaventure, having all in |
3c9cf9c to
d55ecd4
Compare
d55ecd4 to
a309c9f
Compare
|
Needs a rebase |
a309c9f to
9cc2910
Compare
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
9cc2910 to
2790ac6
Compare
|
LGTM |
lowenna
left a comment
There was a problem hiding this comment.
Minor nits which can be followed up later. Otherwise LGTM from the Windows side.
| DefaultRuntimeBinary = "docker-runc" | ||
|
|
||
| // DefaultInitBinary is the name of the default init binary | ||
| DefaultInitBinary = "docker-init" |
There was a problem hiding this comment.
Minor nit, but perhaps this should be in platform files with a comment that it's not used on Windows.
| Version string = "$VERSION" | ||
| BuildTime string = "$BUILDTIME" | ||
| IAmStatic string = "${IAMSTATIC:-true}" | ||
| ContainerdCommitID string = "${CONTAINERD_COMMIT}" |
There was a problem hiding this comment.
Minor nit too - perhaps if not on Windows.
|
LGTM |
|
This is missing |
|
@jhowardmsft I'll make a PR to make those new fields unix only @runcom it looks like docker-proxy doesn't have a |
Add external binaries version to docker info
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com
--
This should prevent us to having to request that information on new issues.