@crosbymichael ooooh, there are much more files where you need to change that :)

@LK4D4 what do you mean?

ahh, yes, the other dockerfiles

@crosbymichael and also rpm and deb stuff :/ and don't forget about specs there, too

@LK4D4 i think I found all the references let me know if I missed anything specifically

LGTM
CI is little dead "though".
Also, I'd love to see CI with --init enabled.

Lets see about setting up CI for this before merging

Anything to make @LK4D4 happy ;)

ping @crosbymichael
experimental failure looks valid:

21:30:55 FAIL: docker_cli_daemon_test.go:2733: DockerDaemonSuite.TestDaemonRestartSaveContainerExitCode
21:30:55 
21:30:55 [d3909b3aae006] waiting for daemon to start
21:30:55 [d3909b3aae006] daemon started
21:30:55 docker_cli_daemon_test.go:2742:
21:30:55     c.Assert(out, checker.Contains, runError)
21:30:55 ... obtained string = "[FATAL tini (5)] Executing child process 'toto' failed: 'No such file or directory'\n"
21:30:55 ... substring string = "exec: \\\"toto\\\": executable file not found in $PATH"
21:30:55 
21:30:55 [d3909b3aae006] exiting daemon

dunno who is toto, though, but probably he is not in Kansas anymore.

@LK4D4 ya, i'm working on fixing it. @tiborvass explained to me what toto was one time

@LK4D4 it's the signature of a French guy debugging software. It's the equivalent of foo. It's also the main character of the stupidest jokes ever.

This may have been no different with grimes, but please (at least on platforms with support) can we compile with Musl libc not glibc.

Compiling tini-static on Alpine it is 31440 bytes, vs 764208 compiled static with glibc.

Alpine does not support all the platforms we do yet, but it should soon, and at least the common ones can have a small init.

@justincormack whats the best way to do this inside our normal build process?

This PR is ready to be reviewed again.

The change I made in daemon/start.go is to make the error checking coming from the container on a start failure case-insensitive which I think is a good overall change to make if we are comparing error strings vs actual exit codes.

LGTM

LGTM

nice, @krallin fyi ;)

Awesome! Looking forward to trying this out in Docker 1.13 😄

Will look at how best to do Musl build within the normal build...

On 9 Nov 2016 4:52 p.m., "Thomas Orozco" notifications@github.com wrote:

Awesome! Looking forward to trying this out in Docker 1.13 😄

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28037 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdcPH5mAuLDpd7vKQGjQr2I6Xf8ei13ks5q8ewngaJpZM4Koq9I
.

@justincormack thanks. I don't know the best way to do it with our current build process

#27359 (with dobi) would make this pretty easy.

We'd have one task for building tini on alpine, and another that depends on it, to build the binary:

image=tini-builder:
  image: docker-tini-dev
  context: dockerfiles/tini/

job=tini:
  use: tini-builder
  mounts: [tini-source]

job=binary:
  use: builder
  depends: [tini]