IPAM driver name should not be required in network create#25803
Closed
yongtang wants to merge 2 commits intomoby:masterfrom
Closed
IPAM driver name should not be required in network create#25803yongtang wants to merge 2 commits intomoby:masterfrom
yongtang wants to merge 2 commits intomoby:masterfrom
Conversation
This fix tries to address the issue raise in 25735 and engine-api/368
where currently IPAM driver name is required in NetworkCreate ('/networks/create').
This fix (together with engine-api update) changes the type of IPAM in NetworkCreate
to be a pointer so that by default IPAM driver name is not needed.
This fix has been tested manually, as is specified in engine-api/368.
This fix fixes 25735.
This fix is related to 25735 and engine-api/368.
A pull request in engine-api has been created separately.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Contributor
Member
|
ping @mrjana |
Contributor
|
@yongtang Can you please rebase? |
Contributor
|
@yongtang engine-api moved into |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This fix tries to address the issue raise in #25735 and docker-archive-public/docker.engine-api#368
where currently IPAM driver name is required in NetworkCreate ('/networks/create').
- How I did it
This fix (together with engine-api update) changes the type of IPAM in NetworkCreate
to be a pointer so that by default IPAM driver name is not needed.
- How to verify it
This fix has been tested manually, as is specified in docker-archive-public/docker.engine-api#368.
- Description for the changelog
This fix fixes #25735.
This fix is related to #25735 and docker-archive-public/docker.engine-api#368.
A pull request in engine-api has been created separately:
docker-archive-public/docker.engine-api#372
Signed-off-by: Yong Tang yong.tang.github@outlook.com