This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Change IPAM driver type to pointer to avoid default value#372
Merged
vdemeester merged 1 commit intodocker-archive-public:masterfrom Aug 30, 2016
yongtang:368-network-create-default-ipam
Merged
Change IPAM driver type to pointer to avoid default value#372vdemeester merged 1 commit intodocker-archive-public:masterfrom yongtang:368-network-create-default-ipam
vdemeester merged 1 commit intodocker-archive-public:masterfrom
yongtang:368-network-create-default-ipam
Conversation
This fix tries to address the issue raised in 368 and docker/25735 where NetworkCreate needs to set up the IPAM driver type. Otherwise an error will be returned. This fix change IPAM driver type to pointer so that `/networks/create` does not the explicit specification of IPAM driver any more. This fix fixes 368. This fix is related to docker/25735. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This was referenced Aug 17, 2016
Contributor
|
LGTM |
Contributor
|
LGTM 🐸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #368 and moby/moby#25735
where NetworkCreate needs to set up the IPAM driver type. Otherwise
an error will be returned.
This fix change IPAM driver type to pointer so that
/networks/createdoes not the explicit specification of IPAM driver any more.
This fix fixes #368.
This fix is related to moby/moby#25803
Signed-off-by: Yong Tang yong.tang.github@outlook.com