fix flaky test TestImportFileWithMessage#23046
Conversation
|
(non-binding) could you please add a test to malformed_host_override_test.go? |
|
Test updated. |
|
Janky failure seems unrelated to this change. |
|
/cc @runcom |
There was a problem hiding this comment.
@runcom This triggered the index out of range
There was a problem hiding this comment.
I meant, this index out of range was from some failed test in some pull request or?
There was a problem hiding this comment.
More precisely, if '\n' appears in the last 7 bytes of the first 4096 bytes, the index out of range error will be triggered because i+n will be greater than 4095.
There was a problem hiding this comment.
There was a problem hiding this comment.
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
|
alright, I got the panic as well, I'll test this out now |
|
LGTM |
…ents Upstream reference: moby#22000 Upstream reference: moby#23046 Upstream reference: moby#22888 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
Note the title understates what this fixes - a suitably malformed request would have crashed the daemon. |
- What I did
Fixes #23045
- How I did it
Fixed the
index out of rangeerror in theMalformedHostHeaderOverrideConnreader.- How to verify it
TESTFLAGS='-check.f DockerSuite.TestImportFileWithMessage' make test-integration-cli- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Shijiang Wei mountkin@gmail.com