Fix a race in daemon/logger/awslogs#22971
Closed
AkihiroSuda wants to merge 1 commit intomoby:masterfrom
Closed
Conversation
Fix moby#22963 (with moby#22969) Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Contributor
|
LGTM |
Member
|
LGTM 👍 |
Contributor
|
@AkihiroSuda I'd really prefer to solve it other way :/ because batch size is 10000. I don't know about real client, but if its PutLogEvents is blocking, then probably mockClient should do the same. If not - then I suppose this fix is good. |
Member
|
@AkihiroSuda Thanks for finding this race! I've opened #22985, which fixes the same race while avoiding copying a slice that could have 10000 elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a race found in #22963
- How I did it
Copied a slice to avoid the race
- How to verify it
TESTDIRS=daemon/logger/awslogs BUILDFLAGS=-race TESTFLAGS="-test.count 100" make test-unitFix #22963 (with #22969)
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
PTAL @samuelkarp