Fix a race in daemon/logger.TestCopier#22969
Merged
cpuguy83 merged 1 commit intomoby:masterfrom May 25, 2016
Merged
Conversation
Update moby#22963 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
6670854 to
ab533f0
Compare
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
May 25, 2016
Fix moby#22963 (with moby#22969) Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Member
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a race found in #22963
- How I did it
Introduced a mutex
- How to verify it
TESTDIRS=daemon/logger BUILDFLAGS=-race TESTFLAGS="-test.count 1000" make test-unitUpdate #22963 (not closable yet, due to another race in awslogs)
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp