Pass upstream client's user agent through to registry on operations beyond pulls#21373
Merged
icecrime merged 1 commit intomoby:masterfrom Mar 22, 2016
Merged
Conversation
…eyond pulls This adds support for the passthrough on build, push, login, and search. Revamp the integration test to cover these cases and make it more robust. Use backticks instead of quoted strings for backslash-heavy string contstands. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Contributor
|
Ping @calavera @stevvooe @anusha-ragunathan (reviewers of the original PR). Makes sense to you? |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
|
Thanks @aaronlehmann! LGTM 👍 |
icecrime
pushed a commit
that referenced
this pull request
Mar 22, 2016
…y-operations Pass upstream client's user agent through to registry on operations beyond pulls
|
I just got around to testing this. User-Agent string looks good on Relevant to #20001 |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for user agent passthrough on build, push, login, and search. It's a followup to #21306, which added this for pull operations.
Revamp the integration test to cover these cases and make it more robust.
Use backticks instead of quoted strings for backslash-heavy string constants.