Reenabled TestPsListContainers* tests and increased sleep time#20961
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Mar 8, 2016
Merged
Reenabled TestPsListContainers* tests and increased sleep time#20961cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Darren Stahl <darst@microsoft.com>
Member
|
tp4 hitting the same error on every PR. |
Contributor
Author
|
Jenkins will ignore unit test failures on Windows now. Rerunning tp4 CI, I'll start the failed ones on other PRs too. I'm investigating why it is failing as well. |
Contributor
Author
|
Guess I should note that this fixes #20819 Still running CI a couple times on windowsTP4 to confirm the fix is enough. |
Contributor
|
LGTM |
Contributor
Author
|
Seems to be reliable so far based on a couple windowsTP4 CI runs. Hoping this holds up when performance is low on CI machines crosses fingers |
Member
|
LGTM |
cpuguy83
added a commit
that referenced
this pull request
Mar 8, 2016
Reenabled TestPsListContainers* tests and increased sleep time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20819
This enables the flakey tests that were failing on WindowsTP4 due to performance degradation. The sleeping container was finishing and exiting prior to the test checking the number of running containers, resulting in an extra container being in the exited state.
Increasing sleep time on Windows to 120 for now, will run windowsTP4 CI a couple times to confirm that this makes the test more reliable. Sleep time can be increased again if necessary.
@jhowardmsft @jstarks
Signed-off-by: Darren Stahl darst@microsoft.com