Move validateContextDirectory to builder package.#20165
Merged
calavera merged 1 commit intomoby:masterfrom Feb 10, 2016
Merged
Conversation
This feels like it's where it belongs and it makes it exported again (which is needed for libcompose that was using it before 1.10). Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2 tasks
Member
|
LGTM |
Contributor
|
Function fits well in builder. Ship it! |
Member
|
LGTM, ping @calavera @tiborvass |
Member
|
LGTM |
Contributor
|
LGTM |
calavera
added a commit
that referenced
this pull request
Feb 10, 2016
…ry-to-builder Move validateContextDirectory to builder package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feels like it's where it belongs and it makes it exported again (which is needed for libcompose that was using it before 1.10). 🐵
This is related to 9e19b48#commitcomment-15231269 and vdemeester/libcompose@a5d1ea8#commitcomment-15973077 (PR docker-archive-public/docker.libcompose#144)
I was wondering if it would make sense to move
getContextFrom…functions, but I didn't want to make a big changes if this is not a direction worth to take 😝. (I'll do a follow-up PR for thoses 😉)./cc @runcom @calavera @tiborvass @anusha-ragunathan @dnephin
🐸
Signed-off-by: Vincent Demeester vincent@sbr.pm