-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Move userns cli test to a separate file, remove experimental flag #20117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM /cc @estesp |
|
LGTM as long as janky is happy |
|
@liron-l this looks good, but one minor nit is that the filename is misspelled for the new file you created. Right now it shows as: Maybe you can fix the name and also squash the 2 commits as it doesn't really need to be 2 different commits. Thanks for this! |
|
damn good catch :) On Mon, Feb 8, 2016 at 1:56 PM, Phil Estes notifications@github.com wrote:
Jessie Frazelle |
|
Fixed. Thanks @estesp good catch 👍 |
Signed-off-by: Liron Levin <liron@twistlock.com>
|
Job: Docker-PRs-WoW-TP4 FAILED: ---
056050.
+ ec=125
+ set +x
----------------------------------
ERROR: Failed to build test binary
----------------------------------
-----------------------------------------------
ERROR: Failed with exitcode 125 at Tue Feb 9 07:33:08 CUT 2016.
-----------------------------------------------
INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Tue Feb 9 07:33:09 CUT 2016 (1m 13s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson5101380273849574846.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---
|
|
LGTM |
Move userns cli test to a separate file, remove experimental flag
Signed-off-by: Liron Levin liron@twistlock.com