Skip to content

Remove unnecessary call to /info endpoint#19973

Merged
tiborvass merged 1 commit intomoby:masterfrom
icecrime:cross_platforms_logout
Feb 3, 2016
Merged

Remove unnecessary call to /info endpoint#19973
tiborvass merged 1 commit intomoby:masterfrom
icecrime:cross_platforms_logout

Conversation

@icecrime
Copy link
Contributor

@icecrime icecrime commented Feb 3, 2016

Sorry for this: #19891 was missing its logout counterpart.

@tiborvass
Copy link
Contributor

LGTM

@LK4D4
Copy link
Contributor

LK4D4 commented Feb 3, 2016

LGTM

@aaronlehmann
Copy link

LGTM

@dmcgowan
Copy link
Member

dmcgowan commented Feb 3, 2016

I find it unnecessary to call cli.electAuthServer() when using a private registry since the value will be immediately overwritten. It would make more sense to only call this on an else block for if len(cmd.Args()) > 0

@LK4D4
Copy link
Contributor

LK4D4 commented Feb 3, 2016

I agree with @dmcgowan

@icecrime
Copy link
Contributor Author

icecrime commented Feb 3, 2016

Good point, updating. Thanks @dmcgowan.

@icecrime icecrime force-pushed the cross_platforms_logout branch from 8ee7ad2 to a749fdb Compare February 3, 2016 20:31
@icecrime
Copy link
Contributor Author

icecrime commented Feb 3, 2016

Updated, PTAL!

@dmcgowan
Copy link
Member

dmcgowan commented Feb 3, 2016

LGTM

@LK4D4
Copy link
Contributor

LK4D4 commented Feb 3, 2016

@icecrime need rebase

@icecrime icecrime force-pushed the cross_platforms_logout branch from a749fdb to 2b50c52 Compare February 3, 2016 21:07
@icecrime
Copy link
Contributor Author

icecrime commented Feb 3, 2016

Updated (@aaronlehmann's PR was merged first, and included the earlier version of this PR).

@aaronlehmann
Copy link

Thanks @icecrime. LGTM.

@tiborvass
Copy link
Contributor

Sorry was my bad

Avoid using the `/info` endpoint in the `login` and `logout` workflows
when the Registry endpoint is overriden by the user through the command
line.

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
@icecrime icecrime force-pushed the cross_platforms_logout branch from 2b50c52 to 243d0d6 Compare February 3, 2016 21:11
@icecrime icecrime changed the title Enable cross-platforms logout from Registry Remove unnecessary call to /info endpoint Feb 3, 2016
@calavera
Copy link
Contributor

calavera commented Feb 3, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants