Tests for PR # 19123: daemon option (--storage-opt dm.basesize) for increasing the base device size on daemon restart#19661
Conversation
173a610 to
3d3b033
Compare
|
adding milestone 1.10 since the relative PR is in the milestone as well |
There was a problem hiding this comment.
not sure about this, maybe we need some testRequirement like this https://github.com/docker/docker/blob/master/integration-cli/requirements.go#L96
which tells us we are on devicemapper (I'm sure CI has a devicemapper build for master)
|
No need to have it in the milestone, since it only adds tests 😁 Thanks @shishir-a412ed! |
24c98ce to
1df00a8
Compare
|
Regarding comment #19661 (comment) @calavera what do you think. you okay using @runcom said he can make that change if we go for the latter option. |
757292e to
937cd9e
Compare
937cd9e to
1904f69
Compare
There was a problem hiding this comment.
can you maybe clean this up a bit, random carrige returns and vars should not be starting with a capital
There was a problem hiding this comment.
I have changed the variable names to start with lowercase. The carriage returns are not random, they are in the output and needs to be trimmed. Otherwise the test fails.
There was a problem hiding this comment.
why are you parsing it as a float only to convert it to an int two lines later
There was a problem hiding this comment.
There is a difference between parsing and casting. strconv.ParseInt() would throw an error if a string with . ("12.59") is passed to it, which means a base device size of 12.59 cannot be directly parsed into an int. We need to parse it as a float and cast it into an int64.
1904f69 to
1e06779
Compare
There was a problem hiding this comment.
can you maybe clean this up a bit, random carrige returns and vars should not be starting with a capital
There was a problem hiding this comment.
Same as above.
477c04e to
bce410e
Compare
There was a problem hiding this comment.
:) This review comment is very hard to fix !
0edb40e to
ccb987c
Compare
…ncreasing the base device size on daemon restart Signed-off-by: Shishir Mahajan <shishir.mahajan@redhat.com>
ccb987c to
0718459
Compare
|
LGTM |
|
LGTM waiting on janky |
Tests for PR # 19123: daemon option (--storage-opt dm.basesize) for increasing the base device size on daemon restart
…sesize) for increasing the base device size on daemon restart Signed-off-by: Shishir Mahajan <shishir.mahajan@redhat.com>
Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com