Fix DockerTrustSuite SetUpTest#19471
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 20, 2016
Merged
Conversation
This hopefully makes DockerTrustSuite.SetUpTest less flaky. Increased the number of attempts to check if Notary is available before giving up. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
There was a problem hiding this comment.
I thought more attempts was better than a longer "sleep", so that we don't make the tests take longer if it does come up fast enough
There was a problem hiding this comment.
I agree. But even after 20 attempts, that is still a 200 ms timeout. I'd suggest raising it even further. It is very possible for I/O or resource starvation to make launching a service take more than 200 ms.
Contributor
There was a problem hiding this comment.
it's 10 * 20 * 20 = 4000 milliseconds = 4 seconds
Member
Author
There was a problem hiding this comment.
@aaronlehmann let's give this a try; we can raise it further if it's still flaky. If it is, we may want to temporarily add some logging to see how long it actually takes, sgty?
Member
Author
|
Janky, why are you failing.. |
Contributor
|
LGTM |
Member
Author
|
Lol, and gccgo is failing on another flaky test 😢 #19368 |
Contributor
|
LGTM. Worth a shot. |
Member
Author
|
It's green, so lets merge! |
thaJeztah
added a commit
that referenced
this pull request
Jan 20, 2016
Fix DockerTrustSuite SetUpTest
Contributor
|
@thaJeztah I'll let Jenkins test this with the DockerTrustSuite enabled on ARM. |
Member
Author
|
@StefanScherer thanks! As mentioned, we can still tweak this, my primary concern was to get the test at least a bit more reliable :-) |
Contributor
|
@thaJeztah Sure! But look, DockerTrustSuite works on ARM: I'll send a PR for that 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully makes DockerTrustSuite.SetUpTest less flaky.
Increased the number of attempts to check if Notary is available before giving up.
fixes #19393 (fingers crossed)