Skip to content

Vendor updated docker/distribution package#19466

Merged
tiborvass merged 1 commit intomoby:masterfrom
aaronlehmann:vendor-distribution
Jan 20, 2016
Merged

Vendor updated docker/distribution package#19466
tiborvass merged 1 commit intomoby:masterfrom
aaronlehmann:vendor-distribution

Conversation

@aaronlehmann
Copy link
Copy Markdown

@aaronlehmann aaronlehmann commented Jan 19, 2016

Fixes #19400

Note that this introduces an incompatibility with Docker 1.10-rc1,
because the media type used for schema1 manifests has been corrected in
the upstream distribution code. Docker 1.10-rc1 won't be able to pull
old manifests from Registry 2.3-rc0 and up, but because of this vendor
update, Docker 1.10-rc2 won't have this problem.

Vendor updated docker/distribution package
588e27f 
Fixes moby#19400

Note that this introduces an incompatibility with Docker 1.10-rc1,
because the media type used for schema1 manifests has been corrected in
the upstream distribution code. Docker 1.10-rc1 won't be able to pull
old manifests from Registry 2.3-rc0 and up, but because of this vendor
update, Docker 1.10-rc2 won't have this problem.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@aaronlehmann
Copy link
Copy Markdown
Author

aaronlehmann commented Jan 19, 2016

cc @docker/distribution-maintainers

@dmcgowan dmcgowan added this to the 1.10.0 milestone Jan 19, 2016
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 19, 2016

LGTM, thanks @aaronlehmann

@BrianBland
Copy link
Copy Markdown
Contributor

BrianBland commented Jan 19, 2016

LGTM

1 similar comment
@tiborvass
Copy link
Copy Markdown
Contributor

tiborvass commented Jan 19, 2016

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 20, 2016

Panic in Janky https://jenkins.dockerproject.org/job/Docker-PRs/22651/console, and experimental https://jenkins.dockerproject.org/job/Docker-PRs-experimental/13862/console

23:26:57 ----------------------------------------------------------------------
23:26:57 FAIL: check_test.go:130: DockerTrustSuite.SetUpTest
23:26:57 
23:26:57 check_test.go:133:
23:26:57     s.not = setupNotary(c)
23:26:57 github.com/docker/docker/integration-cli/_test/_obj_test/trust_server.go:136:
23:26:57     ...open github.com/docker/docker/integration-cli/_test/_obj_test/trust_server.go: no such file or directory
23:26:57 ... Error: Timeout waiting for test notary to become available: Get https://localhost:4443/v2/: dial tcp [::1]:4443: getsockopt: connection refused
23:26:57 
23:26:57 
23:26:57 ----------------------------------------------------------------------
23:26:57 PANIC: docker_cli_build_test.go:5831: DockerTrustSuite.TestBuildContextDirIsSymlink
23:26:57 
23:26:57 ... Panic: Fixture has panicked (see related PANIC)

edit: that one is marked as a flaky test already; #19393

@stevvooe
Copy link
Copy Markdown
Contributor

stevvooe commented Jan 20, 2016

LGTM

@aaronlehmann
Copy link
Copy Markdown
Author

aaronlehmann commented Jan 20, 2016

I don't think the panic is related.

On Jan 19, 2016, at 16:07, Sebastiaan van Stijn notifications@github.com wrote:

Panic in Janky https://jenkins.dockerproject.org/job/Docker-PRs/22651/console

23:26:57 ----------------------------------------------------------------------
23:26:57 FAIL: check_test.go:130: DockerTrustSuite.SetUpTest
23:26:57
23:26:57 check_test.go:133:
23:26:57 s.not = setupNotary(c)
23:26:57 github.com/docker/docker/integration-cli/_test/_obj_test/trust_server.go:136:
23:26:57 ...open github.com/docker/docker/integration-cli/_test/_obj_test/trust_server.go: no such file or directory
23:26:57 ... Error: Timeout waiting for test notary to become available: Get https://localhost:4443/v2/: dial tcp [::1]:4443: getsockopt: connection refused
23:26:57
23:26:57
23:26:57 ----------------------------------------------------------------------
23:26:57 PANIC: docker_cli_build_test.go:5831: DockerTrustSuite.TestBuildContextDirIsSymlink
23:26:57
23:26:57 ... Panic: Fixture has panicked (see related PANIC)
—
Reply to this email directly or view it on GitHub.

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 20, 2016

@aaronlehmann no, I found it was a flaky test, but it looks to be more flaky than before 😢

@tiborvass tiborvass mentioned this pull request Jan 20, 2016
Closed
tiborvass added a commit that referenced this pull request Jan 20, 2016
@tiborvass
Merge pull request #19466 from aaronlehmann/vendor-distribution
7657e23 
Vendor updated docker/distribution package
@tiborvass tiborvass merged commit 7657e23 into moby:master Jan 20, 2016
@aaronlehmann aaronlehmann deleted the vendor-distribution branch January 21, 2016 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

7 participants

@aaronlehmann @thaJeztah @BrianBland @tiborvass @stevvooe @dmcgowan @GordonTheTurtle