Move container configuration types to api/types/container.#18762
Merged
LK4D4 merged 7 commits intomoby:masterfrom Dec 22, 2015
Merged
Move container configuration types to api/types/container.#18762LK4D4 merged 7 commits intomoby:masterfrom
LK4D4 merged 7 commits intomoby:masterfrom
Conversation
375566a to
e1fce33
Compare
Contributor
|
@calavera needs rebase :P |
e1fce33 to
52e5ebf
Compare
Contributor
Author
|
I've rebased these changes and split them in smaller chunks. The last one is still slightly big, but hopefully won't be too hard to review. |
212d6cb to
0590d24
Compare
Contributor
Author
There was a problem hiding this comment.
bad commit, removed!
0590d24 to
81dffac
Compare
Member
|
One nit about tagging go-connections. Looked through the changes, and didn't see strange things :) |
Contributor
|
LGTM |
Contributor
Author
|
@thaJeztah there is a v0.1.0 tag, there are no code changes between the tag and this commit, only docs changed between them. |
Member
|
@calavera should probably be used then 😇 (in a follow up?) |
Contributor
Author
|
@thaJeztah the tag is older than the commit 😄 I'll be happy to tag a v0.2.0 and follow up as soon as we have more code in there. |
Member
|
@calavera hehe, no worries, it's just a nit, so "lgtm" |
Contributor
81dffac to
b0e65ae
Compare
This is a very docker concept that nobody elses need. We only maintain it to keep the API backwards compatible. Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
…rary. It's a very simple function that we can duplicate. Signed-off-by: David Calavera <david.calavera@gmail.com>
- Make the API client library completely standalone. - Move windows partition isolation detection to the client, so the driver doesn't use external types. Signed-off-by: David Calavera <david.calavera@gmail.com>
b0e65ae to
7ac4232
Compare
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Dec 22, 2015
Move container configuration types to api/types/container.
hqhq
added a commit
to hqhq/moby
that referenced
this pull request
Dec 24, 2015
It's in Resources, but wrongly added back to HostConfig in moby#18762 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
aditirajagopal
pushed a commit
to aditirajagopal/docker
that referenced
this pull request
Feb 8, 2016
It's in Resources, but wrongly added back to HostConfig in moby#18762 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That way the structs can be shared between the API client library, the
docker client and the docker daemon without importing the whole docker
project as a library.
All the validations remain in the runconfig package. It's up to client and server to check values.
/cc @dnephin
Signed-off-by: David Calavera david.calavera@gmail.com