Skip to content

Deprecate HostConfig at API container start #17799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calavera merged 1 commit into from
Nov 25, 2015
Merged

Deprecate HostConfig at API container start #17799

calavera merged 1 commit into from
Nov 25, 2015

Conversation

@runcom
Copy link
Member

@runcom runcom commented Nov 8, 2015 •
edited by thaJeztah
Loading

@runcom
Copy link
Member Author

runcom commented Nov 8, 2015

Unluckily, adding a deprecation notice in API response requires modifying the returned status code or add content to a 204 no-content response. I hope the deprecation notice here will suffice.

thaJeztah
thaJeztah reviewed Nov 8, 2015
View reviewed changes
docs/misc/deprecated.md Outdated
Copy link
Member

@thaJeztah thaJeztah Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, don't think we can add this, now that 1.9 was released? @tiborvass wdyt?

Copy link
Member Author

@runcom runcom Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, just copy pasted, it should be 1.10

@runcom runcom force-pushed the deprecate-hc-cont-start branch from 4f726ae to 32e1d9e Compare November 8, 2015 12:28
@LK4D4
Copy link
Contributor

LK4D4 commented Nov 13, 2015

LGTM

@thaJeztah thaJeztah added this to the 1.10 milestone Nov 15, 2015
@thaJeztah
Copy link
Member

thaJeztah commented Nov 15, 2015

ping @cpuguy83 does this LGTY?

@cpuguy83
Copy link
Member

cpuguy83 commented Nov 18, 2015

LGTM

ping @vieux @aluzzardi

@runcom runcom force-pushed the deprecate-hc-cont-start branch from 32e1d9e to bebb2e1 Compare November 20, 2015 19:44
@runcom
Deprecate HostConfig at API container start
3e7405a 
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom runcom force-pushed the deprecate-hc-cont-start branch from bebb2e1 to 3e7405a Compare November 20, 2015 19:46
@runcom
Copy link
Member Author

runcom commented Nov 20, 2015

rebased!

@calavera
Copy link
Contributor

calavera commented Nov 25, 2015

LGTM

calavera added a commit that referenced this pull request Nov 25, 2015
@calavera
Merge pull request #17799 from runcom/deprecate-hc-cont-start
ad67f32 
Deprecate HostConfig at API container start
@calavera calavera merged commit ad67f32 into moby:master Nov 25, 2015
@runcom runcom deleted the deprecate-hc-cont-start branch November 25, 2015 17:14
@aluzzardi
Copy link
Member

aluzzardi commented Nov 25, 2015

👍

@unclejack unclejack mentioned this pull request Jan 3, 2016
Closed
@thaJeztah thaJeztah mentioned this pull request Mar 14, 2016
Closed
@mountkin mountkin mentioned this pull request May 7, 2016
Merged
@shin- shin- mentioned this pull request Jul 25, 2016
Closed
@thaJeztah thaJeztah mentioned this pull request Jan 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

impact/deprecation status/1-design-review

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

deprecate hostConfig on start for API > 1.21

7 participants

@runcom @LK4D4 @thaJeztah @cpuguy83 @calavera @aluzzardi @GordonTheTurtle