Skip to content

Improve port mapping information in the API#1701

Merged
vieux merged 1 commit intomoby:masterfrom
shin-:better_api_ports
Sep 9, 2013
Merged

Improve port mapping information in the API#1701
vieux merged 1 commit intomoby:masterfrom
shin-:better_api_ports

Conversation

@shin-
Copy link
Contributor

@shin- shin- commented Aug 27, 2013

CLI behavior is preserved. See also: docker/docker-py#23

@vieux
Copy link
Contributor

vieux commented Aug 28, 2013

Is there any API changes in this ? If yes, we should update the documentation

@justone
Copy link
Contributor

justone commented Aug 28, 2013

And bump the API version number, just in case someone is relying on the old format?

@mattapperson
Copy link
Contributor

I really need this for a project I am working on... any chance this PR can get cleaned up? I am happy to help, just tell what we want documented

@keeb-zz
Copy link
Contributor

keeb-zz commented Aug 31, 2013

@mattapperson looks like the API version needs to be updated and then this + #1564 are ready to go. Would you like to take a stab at it?

@mattapperson
Copy link
Contributor

Sure, I think I can grab that on tuesday :)

@shykes
Copy link
Contributor

shykes commented Sep 3, 2013

I'm pinging this since it's a blocker for an active user. Is this waiting for review, or does it need additional work?

@crosbymichael
Copy link
Contributor

@shykes @shin- I think this still need the API version to be bumped because it is a breaking change.

@shin- shin- mentioned this pull request Sep 4, 2013
@shin-
Copy link
Contributor Author

shin- commented Sep 9, 2013

@crosbymichael I was told you were planning a network info overhaul on your side too -- would it conflict with this PR? I'd like to be able to merge #1796 because it also solves private registry auth. Available to discuss this anytime =)

@vieux vieux merged commit 98018df into moby:master Sep 9, 2013
@shin- shin- deleted the better_api_ports branch September 11, 2013 22:07
trebonian pushed a commit to trebonian/docker that referenced this pull request Jun 3, 2021
Do not clear ingress network in libnetwork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants