Windows: Get Integration CLI running#15992
Conversation
|
Oh man, this does not scale well. |
|
I'll have a server up by EOD |
|
@cpuguy83 Yeah, things will get better soon, and hopefully rapidly. This also gives the starting point to adding tests for Windows-specific functionality which are sorely still missing. A step in the right direction is certainly better than nothing :) |
|
this is missing changes to start and stop the daemon via the hack/make scripts |
|
@jfrazelle This wasn't intended (yet) to run in Jenkins. This was the precursor to that - just to get to the point where the tests would pass cleanly locally. Changes to hack/make should be in a follow-on PR. |
|
oh sorry i get excite |
|
@cpuguy83 - to appease your feelings, I have a busybox Windows image now. Not perfect, but good enough for now to run some of the CI tests on against a Windows daemon (well around 25 so far and increasing). This will dramatically reduce the number of commenting out of tests, or modifications to tests - essentially reversing much of this PR, but in a controlled manner. However, it will come a number of future PRs, there's still some logistics to work out. Trust me, I know what I'm doing - everything is heading in the right direction. Getting this one merged will allow me to progress with Jess to get the CI server up and running with just a few tests. Others will come online very soon. |
|
@jhowardmsft why not create a Linux-specific testsuite that includes the testRequires line? |
|
Because (as you'll see in future PRs), ultimately many of the tests will run with zero or reasonably little change. This is just a starting point to get to a clean slate. |
|
Fine, LGTM |
|
ah needs rebase so sorry! |
|
@jfrazelle np, rebased. |
|
cool LGTM, just waiting on janky for the merge ;) |
|
Also did another local run against a Windows daemon and it's clean. |
|
\o/ |
|
no that was jenkins being annoying, the servers are being weird im working on it |
|
OK, I'll keep watching it |
|
ok maybe it was.... :( |
|
Yeah, was watching 16086 which was ahead of this one and just failed in the same way. |
Signed-off-by: John Howard <jhoward@microsoft.com>
|
Rebased now 16087 merged. Windows CI should pass. |
|
LGTM |
Windows: Get Integration CLI running
Signed-off-by: John Howard jhoward@microsoft.com
@jfrazelle @swernli. This is an initial swag at getting the integration-cli tests running in Windows to Windows (TP3). This is mainly done by adding requirement
DaemonIsLinuxto tests which use base images which don't exist on Windows, or can't be supported on Windows yet (eg scratch, busybox). This is in preparation for a Windows to Windows CI.We have a new hire who is going to look into how to start enabling chunks of tests on Windows to get better coverage over time.
Local results:
OK: 39 passed, 761 skipped --- PASS: Test (118.43s) PASS ok github.com/docker/docker/integration-cli 118.560s