Carry #14813 on linting package opts and trust#15882
Merged
cpuguy83 merged 3 commits intomoby:masterfrom Aug 27, 2015
Merged
Conversation
1799c45 to
83633b5
Compare
Signed-off-by: Sevki Hasirci <s@sevki.org>
contributes to moby#14756 Signed-off-by: Sevki Hasirci <s@sevki.org>
7a49d65 to
15bfcef
Compare
trust/trusts.go
Outdated
Member
There was a problem hiding this comment.
Surprised the linter didn't pick this one up, but I think the function name should be NewStore
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
15bfcef to
0bd016b
Compare
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
cpuguy83
added a commit
that referenced
this pull request
Aug 27, 2015
Carry #14813 on linting package opts and trust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry the work of @sevki, updated according to comments and rewrote a bit some on opts (that were there before #14756).
/cc @LK4D4 @dmcgowan @tiborvass
Closes #14813.