[Carry #14625] run.md: --expose does NOT override Dockerfile EXPOSE#15675
Merged
thaJeztah merged 2 commits intomoby:masterfrom Aug 19, 2015
Merged
[Carry #14625] run.md: --expose does NOT override Dockerfile EXPOSE#15675thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
Contributor
|
LGTM --- if you can't get to the source in @SpencerBrown comments on the gist let me know. I'll pitch /em to you. |
run.md states that the operator can override all defaults set in the Dockerfile, and explicitly says that `--expose` overrides the `EXPOSE` instruction. Neither of these are true. An `EXPOSE` instruction cannot be overridden, `--expose` can only add additional exposed ports. This change fixes the instructions, and also takes the liberty of crisping up the grammar and phrasing in a place or two. Signed-off-by: Spencer Brown <spencer@spencerbrown.org>
This adds the example gists, provided by Mary Anthony, also fixes a link to the old /terms/ Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
There was a problem hiding this comment.
Removed "or start the client container with --link" from @moxiegirl's gist, because I think that's confusing (--link doesn't publish ports to the host)
Member
Author
|
LGTM, I discussed this with @moxiegirl, and I'm going to merge this one. Additional improvements will be made in a carry/continuation of #12927 Thanks again @SpencerBrown for the initial work |
thaJeztah
added a commit
that referenced
this pull request
Aug 19, 2015
[Carry #14625] run.md: --expose does NOT override Dockerfile EXPOSE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carry of #14625, closes #14625
I kept the original commit of @SpencerBrown intact, rebased on master and applied the gists that @moxiegirl provided on the original PR
I noticed @SpencerBrown had some remarks on the last gist; https://gist.github.com/moxiegirl/ee4dbfb64f1c0191df51#gistcomment-1503908 but have not (yet) incorporated that in this PR