Merged
Conversation
pkg/archive/archive.go
Outdated
Contributor
Author
There was a problem hiding this comment.
ArchiveReader will cause a golint warnings type name will be used as archive.ArchiveReader by other packages, and that stutters; consider calling this Reader, how to rename ArchiveReader, how to rename ArchiveReader? Anyone has a suggestions?
Member
There was a problem hiding this comment.
Naively I would say Reader 😅, that way it does archive.Reader.
1dbcf3a to
ba332b7
Compare
Signed-off-by: Lei Jitang <leijitang@huawei.com>
Contributor
|
LGTM with the changes suggested by @vdemeester 👍 |
Contributor
|
LGTM |
Contributor
|
Thanks @coolljt0725 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Jitang leijitang@huawei.com