fix golint warnings/errors on pkg/system and pkg/stdcopy by WeiZhang555 · Pull Request #15125 · moby/moby

WeiZhang555 · 2015-07-29T15:54:06Z

Part of #14756

Signed-off-by: Zhang Wei zhangwei555@huawei.com

vdemeester · 2015-07-29T16:07:22Z

pkg/system/stat.go

s/return/returns/

gdevillele · 2015-07-29T19:36:07Z

You need a period at the end of the sentences for the func comments.

tiborvass · 2015-07-29T23:31:39Z

@WeiZhang555 sorry needs another rebase :(

WeiZhang555 · 2015-07-30T01:46:05Z

Refreshed, thank you for help reviewing!
ping @tiborvass @gdevillele @vdemeester

tiborvass · 2015-07-30T20:00:09Z

LGTM

WeiZhang555 · 2015-07-31T03:51:19Z

It's strange that it looks like I missed some file, golint pkg/system report nothing but golint pkg/system/events_windows.go report warnings, maybe this is a golint bug?
I'll add the missing

WeiZhang555 · 2015-07-31T10:09:16Z

Updated, please help review @all-maintainers :)

vdemeester · 2015-07-31T10:24:34Z

It's strange that it looks like I missed some file, golint pkg/system report nothing but golint pkg/system/events_windows.go report warnings, maybe this is a golint bug?

@WeiZhang555 golint do not look for other platform go files (or at least the sthg_else.go). That's why we do golint $package/*.go in validate-lint, to make sure we don't miss them 😝 .

vdemeester · 2015-07-31T10:27:14Z

pkg/system/meminfo_unsupported.go

s/doesn't support/is not supporty by/
but it's a nit 😊

WeiZhang555 · 2015-07-31T11:04:34Z

@vdemeester Updated again. Thank you for your kind and patient advice! 😄
Let's see how it works this time.

jmorganca · 2015-07-31T23:36:48Z

Should pkg/archive be added to hack/make/validate-lint?

tiborvass · 2015-07-31T23:39:19Z

@JeffDM No because this PR doesn't address pkg/archive. The only changes in pkg/archive are to rename a variable from pkg/system.

icecrime · 2015-08-03T23:27:08Z

@vdemeester @gdevillele PTAL!

vdemeester · 2015-08-04T06:10:47Z

pkg/system/meminfo_unsupported.go

small nit, a period here 😊.

vdemeester · 2015-08-04T06:14:18Z

LGTM 😉

WeiZhang555 · 2015-08-04T07:41:46Z

@vdemeester period added, thank you! 😆

WeiZhang555 · 2015-08-05T01:26:55Z

Rebased

gdevillele · 2015-08-05T17:45:40Z

$ make test failed here.

WeiZhang555 · 2015-08-06T02:46:16Z

All green now.
Ping @gdevillele @vdemeester @tiborvass @icecrime

gdevillele · 2015-08-06T22:24:21Z

LGTM

WeiZhang555 · 2015-08-11T04:19:31Z

Ping @gdevillele @vdemeester @tiborvass @icecrime
Any progress about this? 😄

vdemeester · 2015-08-11T06:00:34Z

hack/make/validate-lint

Could you remove this one ? pkg/systemd is not here anymore (and thus is not covered by the PR 😅)

Oops, some rebase mistake, will remove it.

WeiZhang555 · 2015-08-11T06:31:03Z

Updated :)

vdemeester · 2015-08-13T07:36:35Z

@WeiZhang555 you're gonna need yet another rebase (to fix the experimental build). sorry 😅 (hopefully this is the last one 😉 )

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>

WeiZhang555 · 2015-08-13T10:52:28Z

OK, updated. 😄

WeiZhang555 · 2015-08-18T00:59:05Z

Ping @gdevillele @vdemeester @tiborvass @icecrime

vdemeester · 2015-08-18T08:27:58Z

still LGTM for me 😉

gdevillele · 2015-08-18T16:25:45Z

LGTM

fix golint warnings/errors on pkg/system and pkg/stdcopy

GordonTheTurtle added the status/0-triage label Jul 29, 2015

WeiZhang555 force-pushed the golint-stdcopy-system branch from c4c0af0 to 197091c Compare July 29, 2015 15:58

vdemeester reviewed Jul 29, 2015
View reviewed changes

pkg/system/stat.go Outdated

Copy link

Member

vdemeester Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/return/returns/

jessfraz added status/2-code-review and removed status/0-triage labels Jul 29, 2015

icecrime mentioned this pull request Jul 29, 2015

Enable golint on the code base #14756

Closed

WeiZhang555 force-pushed the golint-stdcopy-system branch from 197091c to 17147a0 Compare July 30, 2015 01:44

WeiZhang555 force-pushed the golint-stdcopy-system branch from 17147a0 to b266471 Compare July 31, 2015 10:03

vdemeester reviewed Jul 31, 2015
View reviewed changes

pkg/system/meminfo_unsupported.go Outdated

Copy link

Member

vdemeester Jul 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/doesn't support/is not supporty by/
but it's a nit 😊

WeiZhang555 force-pushed the golint-stdcopy-system branch from b266471 to f21d953 Compare July 31, 2015 11:00

vdemeester reviewed Aug 4, 2015
View reviewed changes

pkg/system/meminfo_unsupported.go Outdated

Copy link

Member

vdemeester Aug 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, a period here 😊.

WeiZhang555 force-pushed the golint-stdcopy-system branch from f21d953 to 6de4772 Compare August 4, 2015 07:41

WeiZhang555 force-pushed the golint-stdcopy-system branch from 6de4772 to 3255ee3 Compare August 5, 2015 01:26

WeiZhang555 force-pushed the golint-stdcopy-system branch from 3255ee3 to 1983583 Compare August 6, 2015 01:57

WeiZhang555 force-pushed the golint-stdcopy-system branch from 1983583 to de7532c Compare August 8, 2015 07:18

vdemeester reviewed Aug 11, 2015
View reviewed changes

WeiZhang555 force-pushed the golint-stdcopy-system branch from de7532c to 9a03628 Compare August 11, 2015 06:28

fix golint warnings/errors on pkg/system and pkg/stdcopy

7e420ad

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>

WeiZhang555 force-pushed the golint-stdcopy-system branch from 9a03628 to 7e420ad Compare August 13, 2015 10:50

jessfraz pushed a commit that referenced this pull request Aug 21, 2015

Merge pull request #15125 from WeiZhang555/golint-stdcopy-system

ecff4ba

fix golint warnings/errors on pkg/system and pkg/stdcopy

jessfraz merged commit ecff4ba into moby:master Aug 21, 2015

WeiZhang555 deleted the golint-stdcopy-system branch August 24, 2015 01:30

Conversation

WeiZhang555 commented Jul 29, 2015

Uh oh!

vdemeester Jul 29, 2015

Choose a reason for hiding this comment

Uh oh!

gdevillele commented Jul 29, 2015

Uh oh!

tiborvass commented Jul 29, 2015

Uh oh!

WeiZhang555 commented Jul 30, 2015

Uh oh!

tiborvass commented Jul 30, 2015

Uh oh!

WeiZhang555 commented Jul 31, 2015

Uh oh!

WeiZhang555 commented Jul 31, 2015

Uh oh!

vdemeester commented Jul 31, 2015

Uh oh!

vdemeester Jul 31, 2015

Choose a reason for hiding this comment

Uh oh!

WeiZhang555 commented Jul 31, 2015

Uh oh!

jmorganca commented Jul 31, 2015

Uh oh!

tiborvass commented Jul 31, 2015

Uh oh!

icecrime commented Aug 3, 2015

Uh oh!

vdemeester Aug 4, 2015

Choose a reason for hiding this comment

Uh oh!

vdemeester commented Aug 4, 2015

Uh oh!

WeiZhang555 commented Aug 4, 2015

Uh oh!

WeiZhang555 commented Aug 5, 2015

Uh oh!

gdevillele commented Aug 5, 2015

Uh oh!

WeiZhang555 commented Aug 6, 2015

Uh oh!

gdevillele commented Aug 6, 2015

Uh oh!

WeiZhang555 commented Aug 11, 2015

Uh oh!

vdemeester Aug 11, 2015

Choose a reason for hiding this comment

Uh oh!

WeiZhang555 Aug 11, 2015

Choose a reason for hiding this comment

Uh oh!

WeiZhang555 commented Aug 11, 2015

Uh oh!

vdemeester commented Aug 13, 2015

Uh oh!

WeiZhang555 commented Aug 13, 2015

Uh oh!

WeiZhang555 commented Aug 18, 2015

Uh oh!

vdemeester commented Aug 18, 2015

Uh oh!

gdevillele commented Aug 18, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants