Skip to content

Fix golint warnings for daemon/execdriver/windows#15114

Merged
icecrime merged 1 commit intomoby:masterfrom
hqhq:hq_exedriver_win_lint
Aug 3, 2015
Merged

Fix golint warnings for daemon/execdriver/windows#15114
icecrime merged 1 commit intomoby:masterfrom
hqhq:hq_exedriver_win_lint

Conversation

@hqhq
Copy link
Contributor

@hqhq hqhq commented Jul 29, 2015

Addresses: #14756

Signed-off-by: Qiang Huang h.huangqiang@huawei.com

@lowenna
Copy link
Member

lowenna commented Jul 29, 2015

LGTM. CI is not happy though, unrelated to these changes.

@lowenna
Copy link
Member

lowenna commented Jul 29, 2015

Needs rebasing

@hqhq
Copy link
Contributor Author

hqhq commented Jul 30, 2015

@jhowardmsft Rebased, thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hqhq you should describe what Exec actually does. The fact that implements the Driver interface is a good additional piece of information but secondary.

(same for the other comments)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiborvass Since all these methods in different exec drivers have almost same purpose, and their docs are mostly the same, so as suggested in #14848 (comment), #14848 expended docs in Driver interface, docs for method like Exec can be found in the interface, we can only maintain pertinent details required for these particular implementations.

Addresses: moby#14756

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq hqhq force-pushed the hq_exedriver_win_lint branch from 5dfbff4 to f9b5eb0 Compare August 3, 2015 02:50
@icecrime
Copy link
Contributor

icecrime commented Aug 3, 2015

CI unhappy for unrelated reasons.

LGTM, thanks!

icecrime pushed a commit that referenced this pull request Aug 3, 2015
Fix golint warnings for daemon/execdriver/windows
@icecrime icecrime merged commit ff3adb1 into moby:master Aug 3, 2015
@hqhq hqhq deleted the hq_exedriver_win_lint branch August 4, 2015 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants