Fix golint warnings for daemon/execdriver/windows#15114
Conversation
|
LGTM. CI is not happy though, unrelated to these changes. |
|
Needs rebasing |
cddeb60 to
c6ee8f3
Compare
|
@jhowardmsft Rebased, thanks. |
c6ee8f3 to
5dfbff4
Compare
There was a problem hiding this comment.
@hqhq you should describe what Exec actually does. The fact that implements the Driver interface is a good additional piece of information but secondary.
(same for the other comments)
There was a problem hiding this comment.
@tiborvass Since all these methods in different exec drivers have almost same purpose, and their docs are mostly the same, so as suggested in #14848 (comment), #14848 expended docs in Driver interface, docs for method like Exec can be found in the interface, we can only maintain pertinent details required for these particular implementations.
Addresses: moby#14756 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
5dfbff4 to
f9b5eb0
Compare
|
CI unhappy for unrelated reasons. LGTM, thanks! |
Fix golint warnings for daemon/execdriver/windows
Addresses: #14756
Signed-off-by: Qiang Huang h.huangqiang@huawei.com