Skip to content

daemon/graphdriver/vfs fix lint errors/warnings#15092

Merged
calavera merged 1 commit intomoby:masterfrom
brahmaroutu:lint_daemon_graphdriver_vfs
Aug 3, 2015
Merged

daemon/graphdriver/vfs fix lint errors/warnings#15092
calavera merged 1 commit intomoby:masterfrom
brahmaroutu:lint_daemon_graphdriver_vfs

Conversation

@brahmaroutu
Copy link
Contributor

@brahmaroutu brahmaroutu commented Jul 28, 2015

Addresses #14756
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com

calavera
calavera reviewed Jul 28, 2015
View reviewed changes
daemon/graphdriver/vfs/driver.go Outdated
Copy link
Contributor

@calavera calavera Jul 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put returns nil...

Copy link
Contributor

@calavera calavera Jul 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, something like this might sound better: Put is a noop for vfs, since this driver has no runtime resources to clean up.

@brahmaroutu brahmaroutu force-pushed the lint_daemon_graphdriver_vfs branch 2 times, most recently from 3fcd73f to 05495b8 Compare July 29, 2015 17:55
@tiborvass
Copy link
Contributor

tiborvass commented Jul 31, 2015

@brahmaroutu Sorry but needs a rebase!

@brahmaroutu brahmaroutu force-pushed the lint_daemon_graphdriver_vfs branch from 05495b8 to ce7fff9 Compare July 31, 2015 04:07
@brahmaroutu
Copy link
Contributor Author

brahmaroutu commented Jul 31, 2015

@tiborvass np, I rebased. Looks like validate-lint file may run into more conflicts as we merge anyways.

cpuguy83
cpuguy83 reviewed Jul 31, 2015
View reviewed changes
daemon/graphdriver/vfs/driver.go
Copy link
Member

@cpuguy83 cpuguy83 Jul 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driver implements graphdriver.ProtoDriver.
It uses only basic vfs operations.
In order to support layering, files are copied from the parent layer into the new layer. There is no copy-on-write support.
Driver must be wrapped in NaiveDiffDriver to be used as a graphdriver.Driver

@brahmaroutu brahmaroutu force-pushed the lint_daemon_graphdriver_vfs branch from ce7fff9 to a0766cd Compare July 31, 2015 16:59
@brahmaroutu
Copy link
Contributor Author

brahmaroutu commented Jul 31, 2015

@cpuguy83 I have update the comments as suggested. Please review.

@jmorganca
Copy link
Contributor

jmorganca commented Jul 31, 2015

Seems good once CI passes, no outstanding lints or obvious comment errors other than @cpuguy83 's notes

@cpuguy83
Copy link
Member

cpuguy83 commented Aug 1, 2015

LGTM

@brahmaroutu
daemon/graphdriver/vfs fix lint errors/warnings
3e7f9c6 
Addresses moby#14756
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu brahmaroutu force-pushed the lint_daemon_graphdriver_vfs branch from a0766cd to 3e7f9c6 Compare August 3, 2015 17:46
@calavera
Copy link
Contributor

calavera commented Aug 3, 2015

LGTM

calavera added a commit that referenced this pull request Aug 3, 2015
@calavera
Merge pull request #15092 from brahmaroutu/lint_daemon_graphdriver_vfs
00c1874 
daemon/graphdriver/vfs fix lint errors/warnings
@calavera calavera merged commit 00c1874 into moby:master Aug 3, 2015
@icecrime icecrime mentioned this pull request Aug 5, 2015
Closed
@brahmaroutu brahmaroutu deleted the lint_daemon_graphdriver_vfs branch August 12, 2015 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brahmaroutu @tiborvass @jmorganca @cpuguy83 @calavera @GordonTheTurtle