fix golint errors/warnings of pkg api/#14844
Conversation
|
janky fails, seems not my problem... |
api/common.go
Outdated
There was a problem hiding this comment.
This actually wasn't golint warnings. I think it's enough to write in type docstring, that that type implements sort.Interface
|
@LK4D4 updated, thank you for helping reviewing :) |
api/common.go
Outdated
There was a problem hiding this comment.
Not sure you need to write about the implementation and _O(n_log(n))* stuff. The idea would be to tell what byPrivatePort does, something like : "byPrivatePort is temporary type used to sort types.Port by PrivatePort"
There was a problem hiding this comment.
I'm trying to explain why byPrivatePort would have methods Len()，Swap() and Less()
It's OK for me to remove the O(nlog(n)) stuff since it's not that necessary.
Updated.
There was a problem hiding this comment.
It has these methods to implements sort.Interface 😉 .
|
@vdemeester Updated. 🚀 |
|
@WeiZhang555 could you add the package |
|
@vdemeester Updated. |
|
Conflict and rebased |
|
@vdemeester What's this problem? |
|
@WeiZhang555 Known problem :/ We have no enough entropy. |
|
LGTM |
1 similar comment
|
LGTM |
|
@LK4D4 Got it. :) |
|
super sorry @WeiZhang555 but needs another rebase |
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
|
@tiborvass never mind, rebase done. :) |
|
LGTM |
fix golint errors/warnings of pkg api/
Addresses #14756
Signed-off-by: Zhang Wei zhangwei555@huawei.com