Fix golint warning on pkg/sysinfo#14840
Merged
runcom merged 1 commit intomoby:masterfrom Aug 4, 2015
HuKeping:golint-pkg-sysinfo
Merged
Fix golint warning on pkg/sysinfo#14840runcom merged 1 commit intomoby:masterfrom HuKeping:golint-pkg-sysinfo
runcom merged 1 commit intomoby:masterfrom
HuKeping:golint-pkg-sysinfo
Conversation
pkg/sysinfo/sysinfo.go
Outdated
Member
There was a problem hiding this comment.
I think these exported fields should be documented
Contributor
Author
There was a problem hiding this comment.
It seems golint will not get crazy about that, but I agree with you it is better to add comments on those exported fields.
Contributor
|
@HuKeping Would you mind to add |
Contributor
Author
|
OK, I'll do that |
pkg/sysinfo/sysinfo_windows.go
Outdated
Contributor
|
LGTM |
Contributor
|
I'm getting the warning: |
Member
Contributor
Author
|
I'll check that. There is no more warning on my |
Contributor
Author
|
updated, thanks @JeffDM |
Signed-off-by: Hu Keping <hukeping@huawei.com>
Member
|
LGTM, waiting windows janky |
runcom
added a commit
that referenced
this pull request
Aug 4, 2015
Fix golint warning on pkg/sysinfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14756
Signed-off-by: Hu Keping hukeping@huawei.com