/graph/tag fix lint errors/warnings#14828
Merged
calavera merged 1 commit intomoby:masterfrom Aug 7, 2015
Merged
Conversation
graph/tags/tags.go
Outdated
Member
There was a problem hiding this comment.
this should be DefaultTag
DefaultTag defines the default tag used when performing images related actions and no tag string is specified
maybe @stevvooe has a better comment for this tho
Contributor
Author
There was a problem hiding this comment.
I would keep it DEFAULTTAG, if not I will have to change the api package.
Contributor
Author
There was a problem hiding this comment.
I have renamed DEFAULTTAG to DefaultTag. Please review.
407363a to
7e85f70
Compare
Contributor
|
LGTM |
7e85f70 to
9cc2ce3
Compare
Contributor
|
needs rebase |
4445992 to
bb7205a
Compare
Contributor
|
@brahmaroutu needs a rebase |
bb7205a to
e54e794
Compare
Contributor
Author
|
@tiborvass I have rebased the code. |
Contributor
|
@brahmaroutu sorry needs another rebase -_- |
Addresses moby#14756 Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
e54e794 to
d9b2612
Compare
Contributor
Author
|
@tiborvass Rebased. |
Contributor
|
LGTM. Merging! |
calavera
added a commit
that referenced
this pull request
Aug 7, 2015
/graph/tag fix lint errors/warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #14756
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com