Conversation
pkg/mflag/flag.go
Outdated
There was a problem hiding this comment.
better to be fs
you also changed the method receiver name and tests are failing for this
There was a problem hiding this comment.
ok will change it. (and ty silly me)
I'll add pkg/mflag to the automatically linted packges too.
There was a problem hiding this comment.
there is a compilation issue because cmd is still referenced in line 1077.
3524205 to
2acc149
Compare
7e289d6 to
2c76004
Compare
|
@runcom does this LGTY ? |
|
Please, do NOT merge this PR just yet. I'd like to land #13771 first. |
|
Nothing bad about the changes, but we need the other PR merged as soon as possible and I'd like to avoid any friction before that happens. |
|
@fcantournet we merged #13771 yesterday and this is ready to merge. Unfortunately, we added a couple new methods to the mflag package in master. Do you want to rebase this change and cover the new additions? |
|
@calavera Sure, I'll rebase and finish the job. |
2c76004 to
8841fd8
Compare
|
LGTM |
pkg/mflag/flag.go
Outdated
There was a problem hiding this comment.
s/Indicates/indicates/ and a period at the end 😊
8841fd8 to
199d612
Compare
|
@calavera test seem flaky. The errors don't seem to be link with this patch. is there a way to retrigger the checks ? |
Signed-off-by: Félix Cantournet <felix.cantournet@cloudwatt.com>
199d612 to
8e6ad21
Compare
|
LGTM |
1 similar comment
|
LGTM |
|
Ok, it compiles |
Addresses (partly) : #14756
Signed-off-by: Félix Cantournet felix.cantournet@cloudwatt.com