golint: Lint pkg/namesgenerator#14805
Merged
icecrime merged 1 commit intomoby:masterfrom Jul 21, 2015
Merged
Conversation
Member
|
LGTM pending janky. |
Contributor
There was a problem hiding this comment.
mispell :) 'focused_turing'i
Contributor
Contributor
Author
There was a problem hiding this comment.
@LK4D4 nope - https://github.com/dave-tucker/docker/blob/golint_namesgen/pkg/namesgenerator/names-generator.go#L34
according to google it can be focused or focussed - I would have used the later but meh. yay for ambiguous english!
Contributor
Author
There was a problem hiding this comment.
but good call on the trailing "i" though - my bad vim'ing 😄
Contributor
|
overall LGTM (thanks for the additional tests). I just one question and typo found by @LK4D4 |
Also addded a couple more tests Updates moby#14756 Signed-off-by: Dave Tucker <dt@docker.com>
983ecb2 to
c5667bc
Compare
Contributor
|
LGTM 👍 |
icecrime
pushed a commit
that referenced
this pull request
Jul 21, 2015
golint: Lint pkg/namesgenerator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also addded a couple more tests
Updates #14756
Signed-off-by: Dave Tucker dt@docker.com