Conversation
|
Ok so I have a feeling that the issues in CI are related to the simply changing |
pkg/nat/nat.go
Outdated
There was a problem hiding this comment.
Format? What do they mean? How should it be used?
aa9e90a to
2ec2524
Compare
|
Updated based on @stevvooe's review |
|
@dave-tucker I would consider code that relies on untagged json structs for serialization to be broken. What tests are broken? |
|
@stevvooe failure was in the integration tests My hackaround feels wrong on many levels but I'm not really sure what to do here 😕 |
|
@dave-tucker I see. This is very unfortunate that we let an internal struct escape into API. Your fix is acceptable. LGTM |
Updates moby#14756 Signed-off-by: Dave Tucker <dt@docker.com>
|
LGTM |
golint: Fix issues in pkg/nat
Updates #14756
Signed-off-by: Dave Tucker dt@docker.com