Merged
Conversation
daemon/network/settings.go
Outdated
Member
There was a problem hiding this comment.
Address represents an IP address
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
2ef5afe to
7be8336
Compare
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
runcom
added a commit
that referenced
this pull request
Jul 21, 2015
golint on daemon/network package
Contributor
There was a problem hiding this comment.
This isn't really sufficient. It should provide information about why this type exists, why we've opted away from using standard types (ie net.IP). It is also missing documentation for the fields.
Contributor
|
This package needs another pass. These comments aren't providing any value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #14756
Signed-off-by: Zhang Wei zhangwei555@huawei.com