Conversation
There was a problem hiding this comment.
why don't we call it just Flags so it will be builder.Flags? and also the functions below like NewFlags instead of NewBFlags etc etc (and filename to just builder/flag.go :))
There was a problem hiding this comment.
Since we have bflag.go, I thought we already consider bflag for short of buildflag, and bflag would be more meaningful than just flag. Personally I don't like that common word as a variable or method's name, it's painful when we jump between these tags 😞
If you insist, I surely can change the name 😄
There was a problem hiding this comment.
I tend to agree with @hqhq - having 'b' or something (like "builder") in there to make it clear its not the same "flags" as the cmd line stuff is useful. But no biggie either way.
|
@hqhq there's some failings in builder unit tests |
|
@runcom Fixed, all green now 😄 |
builder/bflag.go
Outdated
builder/command/command.go
Outdated
There was a problem hiding this comment.
s/define constant/Define constants/
|
@duglin Thanks, updated. |
|
LGTM |
builder/internals.go
Outdated
There was a problem hiding this comment.
Pretty sure this should be private. Let's fix this. Then you don't need docstring at all :)
There was a problem hiding this comment.
Right, didn't check it.
Addresses: moby#14756 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
|
@LK4D4 updated, thanks. |
|
LGTM |

Addresses: #14756
Signed-off-by: Qiang Huang h.huangqiang@huawei.com