Skip to content

fix golint errors/warnings#14784

Merged
tiborvass merged 1 commit intomoby:masterfrom
brahmaroutu:lint_api_client
Jul 29, 2015
Merged

fix golint errors/warnings#14784
tiborvass merged 1 commit intomoby:masterfrom
brahmaroutu:lint_api_client

Conversation

@brahmaroutu
Copy link
Contributor

@brahmaroutu brahmaroutu commented Jul 21, 2015

Addresses #14756
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com

@vdemeester
Copy link
Member

vdemeester commented Jul 21, 2015

@brahmaroutu you might wanna see/configure your ~/.gitconfig with names and email because right now your commit appear as root which doesn't say much >.<.

@cpuguy83
Copy link
Member

cpuguy83 commented Jul 21, 2015

Test is failing.

@icecrime icecrime mentioned this pull request Jul 21, 2015
Closed
@brahmaroutu brahmaroutu force-pushed the lint_api_client branch 2 times, most recently from 8e83072 to 25d8537 Compare July 21, 2015 21:07
@brahmaroutu brahmaroutu force-pushed the lint_api_client branch 5 times, most recently from c292e26 to b6d6181 Compare July 23, 2015 22:40
@vdemeester
Copy link
Member

vdemeester commented Jul 26, 2015

@brahmaroutu needs a rebase 😊 and could you add api/client to ./hack/make/validate-lint.

@brahmaroutu brahmaroutu force-pushed the lint_api_client branch 6 times, most recently from 8dd6725 to b7a039a Compare July 27, 2015 14:06
@LK4D4
Copy link
Contributor

LK4D4 commented Jul 27, 2015

Hmm, test still failing.

@brahmaroutu brahmaroutu force-pushed the lint_api_client branch 3 times, most recently from be6f616 to a9b7a5c Compare July 28, 2015 16:09
RichardScothern
RichardScothern reviewed Jul 28, 2015
View reviewed changes
api/client/cli.go Outdated
Copy link
Contributor

@RichardScothern RichardScothern Jul 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'anonymous' can be removed, as it can be confused with Go's package init() function

@brahmaroutu brahmaroutu force-pushed the lint_api_client branch 2 times, most recently from c89fcd4 to f7ff135 Compare July 29, 2015 16:12
@vdemeester
Copy link
Member

vdemeester commented Jul 29, 2015

@brahmaroutu needs a rebase 😊.

@brahmaroutu
api/client fix golint errors/warnings
929f2c2 
Addresses moby#14756

Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@tiborvass
Copy link
Contributor

tiborvass commented Jul 29, 2015

Things are moving fast around here :)

@brahmaroutu
Copy link
Contributor Author

brahmaroutu commented Jul 29, 2015

Rebased. Please review.

tiborvass
tiborvass reviewed Jul 29, 2015
View reviewed changes
docker/docker.go Outdated
Copy link
Contributor

@tiborvass tiborvass Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brahmaroutu os.stderr is wrong, it's either stderr or os.Stderr

Copy link
Contributor Author

@brahmaroutu brahmaroutu Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I changed the code.

@tiborvass
Copy link
Contributor

tiborvass commented Jul 29, 2015

LGTM

tiborvass added a commit that referenced this pull request Jul 29, 2015
@tiborvass
Merge pull request #14784 from brahmaroutu/lint_api_client
e77ea5a 
fix golint errors/warnings
@tiborvass tiborvass merged commit e77ea5a into moby:master Jul 29, 2015
@brahmaroutu brahmaroutu deleted the lint_api_client branch August 12, 2015 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@brahmaroutu @vdemeester @cpuguy83 @LK4D4 @tiborvass @RichardScothern @jessfraz @GordonTheTurtle