Update documentation according to opts updates (#13694)#14727
Update documentation according to opts updates (#13694)#14727thaJeztah merged 1 commit intomoby:masterfrom
Conversation
docs/reference/commandline/run.md
Outdated
There was a problem hiding this comment.
I'd remove the first line and simplify the note to something like
> **Note**: Environment variables names must consist solely of letters, numbers,
> and underscores - and cannot start with a number.
There was a problem hiding this comment.
@SvenDowideit feels way better 😊 updating it 😉
74f915c to
00568aa
Compare
docs/userguide/dockervolumes.md
Outdated
There was a problem hiding this comment.
I think the "As described before," is not needed (Sure, it may be duplicated information but that doesn't hurt).
00568aa to
7905312
Compare
|
@vdemeester added some more notes (sorry, I was called away during reviewing) Question; #13694 is not yet in a release, or is it? If not, I think we should add "impact" labels ("impact/changelog" and "impact/ui"), because the validation-rules changed? |
7905312 to
ccbafbe
Compare
|
@thaJeztah It will be in I agree with you on the |
ccbafbe to
6285f27
Compare
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
6285f27 to
dc8b765
Compare
|
Thanks, LGTM! |
Update documentation according to opts updates (#13694)
With #13694 two small things have changed :
--envand--envfileare now validated according to the following definition : "Environment variables set by the user must have a name consisting solely of alphabetics, numerics, and underscores - the first of which must not be numeric.".-v containerPath:roas option forrun(andcreate, …).I realized I did not think of the documentation when submitting #13694, so this ones try to update the few things it should.
-v containerPath:roSigned-off-by: Vincent Demeester vincent@sbr.pm