Windows: Refactor network modes#14133
Conversation
|
LGTM |
daemon/daemon_windows.go
Outdated
There was a problem hiding this comment.
if hostConfig == nil || hostConfig.Links == nil {
return nil
}Because the rest of the code is the import stuff, nice to have one less indentation
Signed-off-by: John Howard <jhoward@microsoft.com>
|
@cpuguy83 Comments addressed :) Waiting for Jenkins |
|
LGTM, though naming is a bit funky. @calavera Still good for you? |
|
Easy to rename, but I'm struggling to come up with something better? Open to suggestions :) |
There was a problem hiding this comment.
What is the purpose of default mode to have multiple parts ?
In the case of Linux, multiple parts separated by ":" is used for container namespace. which is not applicable for windows.
There was a problem hiding this comment.
Purely to keep it in sync with Linux (for now). You're right, none of this does anything quite yet - I can remove that once we have real code in there. I just wanted to get us off overloading 'bridge' in the first instance.
|
@jhowardmsft reviewed it only from the perspective of making sure the linux side of things stay as is. just a minor comment. otherwise LGTM. |
|
Still LGTM. Merging! thank you 🎆 |
Windows: Refactor network modes
Signed-off-by: John Howard jhoward@microsoft.com
@swernli @mavenugo @mrjana
This PR is part of the proposal described in docker/docker issue 10662 to port the docker daemon to Windows. This refactors the network modes for Windows support.