Skip to content

Conversation

@mavenugo
Copy link
Contributor

Based on various discussions and inputs, we have a simplified proposal to address the network UI
separate from services ui. This PR brings in the network ui & api provided by libnetwork and hooking it
to be part of docker.
All of these are defined under experimental tag in order to get user feedback before making it officialy into the docker ui chain.

mavenugo added 2 commits June 18, 2015 12:07
This commit also brings in the ability to specify a default network and its
corresponding driver as daemon flags. This helps in existing clients to
make use of newer networking features provided by libnetwork.

Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com>
@icecrime
Copy link
Contributor

Review this this morning with Madhu. I think the integration points for both CLI commands and API endpoints and clean and simple (directly goes to libnetwork, and it's still experimental).

The one tricky thing is the dance around --net modes, but that constraint stems from our requirement of backward compatibility. We shouldn't be changing the meaning of --net=bridge, and yet we need to allow changing the default behavior to something fancier (e.g., multihost) using a daemon-wide flag.

So LGTM for me.

@calavera
Copy link
Contributor

LGTM. Moving to docs review.

@moxiegirl
Copy link
Contributor

I don't have scope today for a full doc review. This is in experimental I see. So, let's merge it. Just to remind everyone, experimental "docs" live in the repo and doesn't go out to docs.docker.com

calavera added a commit that referenced this pull request Jun 19, 2015
@calavera calavera merged commit df73d5e into moby:master Jun 19, 2015
@cpuguy83
Copy link
Member

#boom

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavenugo can you open an issue and create a follow-up PR to fill in the right link to that issue? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants