-
Notifications
You must be signed in to change notification settings - Fork 18.9k
experimental network ui #14023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental network ui #14023
Conversation
This commit also brings in the ability to specify a default network and its corresponding driver as daemon flags. This helps in existing clients to make use of newer networking features provided by libnetwork. Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
Review this this morning with Madhu. I think the integration points for both CLI commands and API endpoints and clean and simple (directly goes to libnetwork, and it's still experimental). The one tricky thing is the dance around So LGTM for me. |
|
LGTM. Moving to docs review. |
|
I don't have scope today for a full doc review. This is in experimental I see. So, let's merge it. Just to remind everyone, experimental "docs" live in the repo and doesn't go out to docs.docker.com |
|
#boom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mavenugo can you open an issue and create a follow-up PR to fill in the right link to that issue? Thanks!
Based on various discussions and inputs, we have a simplified proposal to address the network UI
separate from services ui. This PR brings in the network ui & api provided by libnetwork and hooking it
to be part of docker.
All of these are defined under experimental tag in order to get user feedback before making it officialy into the docker ui chain.