Restore --default-gateway{,-v6} daemon options.#13757
Merged
Conversation
This was added before the libnetwork merge, and then lost. Fixes #13755. Signed-off-by: Eric-Olivier Lamey <eo@lamey.me>
Contributor
|
ping @mrjana |
Contributor
|
LGTM |
Member
Contributor
|
@thaJeztah @eolamey already added the required integration tests |
Member
|
@mrjana oh! sorry, I saw the question and didn't check further. Apologies for the noise :) |
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jun 6, 2015
…teway-back-please
Restore --default-gateway{,-v6} daemon options.
Member
|
Thanks @eolamey! Ping @jfrazelle for cherry pick |
Contributor
|
cherry-picked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13755.
I could not find integration tests for IPv6, so I didn't add any, although I'm not quite comfortable with that. I'm not sure adding them would be easy, as the tests would depend on proper IPv6 configuration, and I couldn't get the
--bipoption to work anyway. If someone wants to help me with this, I would be glad to try it.