Conversation
|
/cc @mavenugo |
pkg/plugins/plugins.go
Outdated
|
Looks like needs some debug cleanups. |
|
@calavera Thanks. Also thanks for making it a pkg. Will get back to you shortly after a short PoC integration with |
|
@LK4D4 fixed debug statements. |
pkg/plugins/plugins.go
Outdated
pkg/plugins/discovery_test.go
Outdated
There was a problem hiding this comment.
Seems like we need another mutex in container :) Because this might be a problem.
There was a problem hiding this comment.
I don't think locking should be responsibility of the plugin. Let's leave that to the container that uses it.
There was a problem hiding this comment.
Yeah, you're right. But this will be called under container.Lock() which we can't hold for long time.
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com>
Signed-off-by: Madhu Venugopal <madhu@docker.com> (cherry picked from commit 7fc16f4)
Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@mavenugo I've incorporated your handle function to the PR. |
|
@calavera Thanks. appreciate it & its a LGTM for |
Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
LGTM |
1 similar comment
|
LGTM |
Remote plugins plumbing.
Package extracted from #13161 that includes only the plumbing to create rpc plugins.
See the next files to understand how to use it:
Adapter to hide rpc logic: https://github.com/docker/docker/pull/13161/files#diff-3df42339ab51e1cd0c14cccc2e4619ec
Interface to implement local and remote calls: https://github.com/docker/docker/pull/13161/files#diff-b880a48e8fc6e68e38502dcc73822c33
Proxy to perform the rpc calls: https://github.com/docker/docker/pull/13161/files#diff-51417af0fa9465a8b5415c0fbb16a099
Plugin memory storage for configured drivers: https://github.com/docker/docker/pull/13161/files#diff-54fddc8de3b5f9c246fa36477bfab894
Signed-off-by: David Calavera david.calavera@gmail.com