Remove engine/job from graph #12710
Merged
Remove engine/job from graph #12710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @LK4D4 @duglin @jfrazelle |
Member
Author
There was a problem hiding this comment.
Didn't yet reimplemented this because......what we are testing here? are we really testing the go http package?
Contributor
There was a problem hiding this comment.
yeah, you don't need reimplement such crap
f56b31a to
846fa5e
Compare
846fa5e to
c560868
Compare
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
c560868 to
fa2c68a
Compare
Contributor
|
can you |
Member
Author
|
@jfrazelle yup, I'll make another pr to address the complete removal, branching out from this one |
Contributor
|
Thanks @runcom !!! |
Contributor
There was a problem hiding this comment.
hmm i'd prefer not having lookupraw...
Contributor
There was a problem hiding this comment.
Why? I think it is better than have deprecated argument.
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
🎊 |
jessfraz
pushed a commit
that referenced
this pull request
Apr 23, 2015
Remove engine/job from graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca me@runcom.ninja