Add --uts=host to allow sharing the UTS namespace#12667
Add --uts=host to allow sharing the UTS namespace#12667thaJeztah merged 1 commit intomoby:masterfrom
Conversation
|
A bit of context in here #12185: I'm going to tentatively push this to |
daemon/execdriver/driver.go
Outdated
There was a problem hiding this comment.
Style: this should be UTS. Please see https://code.google.com/p/go-wiki/wiki/CodeReviewComments#Initialisms.
There was a problem hiding this comment.
That's inconsistent with Ipc and Pid above. Do we care?
There was a problem hiding this comment.
@ibuildthecloud Preferably, we'd follow the Go style guidelines.
There was a problem hiding this comment.
Okay, I will change the type to UTS
|
LGTM |
|
I think we can move to docs review LGTM |
|
@ibuildthecloud Are we not fixing the initialisms? |
|
I'll update that in the next hour. |
|
@ibuildthecloud I see that docs aren't there yet, feel free to ping me once they are added. Apart from the "usual" places, perhaps this needs a mention in the "Advanced networking" article https://docs.docker.com/articles/networking/ as well. |
|
Change @thaJeztah I did look at that networking article and was a bit overwhelmed at where I should put the changes. |
|
@ibuildthecloud yes, it's quite a piece. I'm not really an expert in this area, but I assumed some mentioning there could be useful. Perhaps someone can give a suggestion what kind of information / examples would be useful there? @LK4D4 @stevvooe I'm okay with adding more information later, but a "in depth" article/reference that doesn't mention a particular option doesn't feel right :) |
There was a problem hiding this comment.
I think this should also be added to the "create" section.
(Unrelated, but it looks like --pid is missing there as well if create supports that, but that's better left for another PR)
There was a problem hiding this comment.
Also, should we add the possible value(s) here somehow?
There was a problem hiding this comment.
The only valid value is really host.
|
@ibuildthecloud thanks! Added some comments; #12667 (comment) and #12667 (comment) should still be looked at by the other docs-maintainers. Also, before merging, the commits need to be squashed. If you can do so when addressing the docs reviews, that would be great (in case we overlook it before merging 😄) |
|
@ibuildthecloud sorry needs rebase :S |
21c802f to
dd0c1c6
Compare
|
@tiborvass Another day, another rebase :) |
docs/sources/reference/run.md
Outdated
|
Thanks! One small typo, other than that, docs LGTM ping @fredlf @jamtur01 @moxiegirl @SvenDowideit I left #12667 (comment) for you 😄 |
|
Docs LGTM |
Signed-off-by: Darren Shepherd <darren@rancher.com>
|
Ok, I think this has all the required LGTMs. The Uts -> UTS change was done after the code LGTM, but I think that should be OK. (Famous last words) Merging |
Add --uts=host to allow sharing the UTS namespace
Currently it is not possible to share the UTS namespace with the host.
--net=hoststill creates a private UTS namespace. This PR adds the ability to share the UTS namespace. This means a container could set the hostname of the host, or as the hostname of the host changes, the hostname of the container will change too.