Remove job image_get #12601
Merged
Remove job image_get #12601
+4
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graph/service.go
Outdated
Member
Author
There was a problem hiding this comment.
only not sure about this..because comment below say we won't expose full image struct so I declared this here, maybe there's a better place?
Contributor
There was a problem hiding this comment.
I think it is just crap, use s.ImageLookup instead of GetImageDetail everywhere.
b850aa1 to
5465a4a
Compare
Contributor
|
LGTM |
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
5465a4a to
d07fe18
Compare
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca me@runcom.ninja