Remove engine from trust #12564
Merged
Remove engine from trust #12564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Contributor
Author
|
ping @duglin @tiborvass @runcom |
Member
|
👍 (for what it counts 😊) |
Contributor
There was a problem hiding this comment.
any reason you're not just using 'verified' here since you just assign 'v' to 'verified' later on?
Contributor
Author
There was a problem hiding this comment.
Yup, I don't want to have var err error because then reader would suspect that that var has meaning and would search that meaning in code below, but there is no meaning. Also it is easy to do verified, err := mistake and then verified will be false forever.
Contributor
|
LGTM |
2 similar comments
Member
|
LGTM |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.