remove job from pull and import #12490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #12396 Signed-off-by: Simei He <hesimei@zju.edu.cn> Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Contributor
Author
|
ping @calavera @duglin @tiborvass |
Contributor
There was a problem hiding this comment.
I think that InConfig can be decoded with runconfig.DecodeContainerConfig
Contributor
Author
There was a problem hiding this comment.
InConfig actually not config. It is archive
Contributor
|
LGTM |
Contributor
|
It looks like this has a small conflict with #12457. I'll rebase that pr when this is in master. |
Member
|
Even TestPullVerified worked, LGTM :) |
cpuguy83
added a commit
that referenced
this pull request
Apr 17, 2015
remove job from pull and import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12396