Remove builtins #12486
Merged
Remove builtins #12486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
Contributor
|
COOL |
Contributor
There was a problem hiding this comment.
why the change from 5 to 10?
Member
Author
There was a problem hiding this comment.
cause I was running test and I think because laptop was under heavy load (compiling kernel) and this tests timed out, I don't know if this was the problem, test runs ok now, I can change it back
Contributor
There was a problem hiding this comment.
I think it is okay. It won't hurt fast machines, but your laptop should pass tests too.
Member
Author
There was a problem hiding this comment.
Yeah it currently runs ok even with 5 seconds, but was under heavy load (make -j14) and I suppose it was timing out for this
Contributor
|
I ❤️ @runcom |
Member
Author
|
@tiborvass :) |
Contributor
|
LGTM |
Contributor
|
LGTM |
Member
Author
|
cool just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca me@runcom.ninja