Move integration/server_test tests to integration-cli #12282
Conversation
|
@cpuguy83 can you please rebase this? |
f9d52fb to
2cbdd06
Compare
|
Rebased, failures are due to some bad tests on master after change to |
5e8bf03 to
6dd1508
Compare
|
@cpuguy83 Haha, guess what :) |
6dd1508 to
f356ebe
Compare
|
rebased again. |
There was a problem hiding this comment.
Shouldn't you check that hostname is really set?
There was a problem hiding this comment.
The other test was not, certainly can.
There was a problem hiding this comment.
Yeah, just looks weird without it. can be done just with "hostname" command I think.
f356ebe to
4b3f399
Compare
|
@LK4D4 Updated |
|
@cpuguy83 Fail on test. |
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
4b3f399 to
02706a4
Compare
|
Fixed |
|
Lol, |
|
TBH I reviewed superficially and haven't looked in details to see if each test did exactly what it used to, but overall LGTM. |
There was a problem hiding this comment.
this can be looped as well:
cases := []struct{
filter string,
expected int,
}
{
{"utest*/*", 2},
{"utest", 1},
// ..and so on
}
for _, c := range cases {
if images := getImages(c.filter); len(images[0].RepoTags) != c.expected {
t.Fatal(errMsg) // <--probably put c.filter here. also good to have something like "expected: %d, got: %d"
}
}
|
LGTM except one suggestion. somebody should really fix that |
|
LGTM |
Move integration/server_test tests to integration-cli
No description provided.