Remove Job from History API #12260
Merged
Remove Job from History API #12260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Probably some integration test that needs to be modified here to clear up janky. |
Contributor
Author
|
yeah, i am working on that :) EDIT: @cpuguy83 I think the integration-cli tests should have already covered it and i removed the test from server_unit_test.go? |
graph/history.go
Outdated
Contributor
There was a problem hiding this comment.
This is sorta weird error. It is about old jobs syntax. I think it is okay to return error right from s.LookupImage.
Contributor
Author
|
ping @LK4D4 updated |
Contributor
|
LGTM |
a part of issue #12151 Signed-off-by: Hu Keping <hukeping@huawei.com>
Member
|
Yes, it looks like that test wasn't really testing anything to begin with.... other than that you can create a job and pass in an arg to it.... definitely good to delete it. |
Member
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a part of issue #12151
Signed-off-by: Hu Keping hukeping@huawei.com