Remove job from resize&execResize #12254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/server/server.go
Outdated
Contributor
There was a problem hiding this comment.
I think http writes 200 automatically on handler return.
Member
Author
There was a problem hiding this comment.
Yes, back at my laptop in some minutes and I'll push force
Member
Author
There was a problem hiding this comment.
not sure if exporting getExecConfig from daemon would have been a good idea so I just left this here in resize.go
Contributor
There was a problem hiding this comment.
Yeah, exec is tough. I think it is okay for now.
Contributor
|
@runcom Need rebase |
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
7fd0348 to
e290a22
Compare
Member
Author
|
@LK4D4 rebased and removed comments |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Apr 10, 2015
Remove job from resize&execResize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12151
Signed-off-by: Antonio Murdaca me@runcom.ninja